[TIL/fairer] 2022-05-14 jpa로직 구현

😊 Today I Learned

집안일 전체 조회 API - jwt token 적용

집안일 전체 조회 API를 개발할 때, 날짜를 받아와서 해당 날짜에 해당하는 집안일을 리턴하도록 했었다. 로그인 기능이 구현되고, jwt가 추가되면서 토큰을 통해 memberId를 받아와서 날짜 + memberId까지 조인해서 가져와야 했다.

jwt는 나중에 수정하더라도 memberId까지 받아서 가져오도록 설계했어야 했는데, 지금까지 날짜만 받아 모든 유저의 집안일을 가져오도록 구현하고 있었다는게 충격이었다. 이정도로 기본적인 부분도 놓치고 있었다니..😇

 

HouseWorkController 수정 전

    @GetMapping(value = "")
        public ResponseEntity<HouseWorkDateResponseDto> getHouseWork(@RequestParam("scheduledDate") String scheduledDate){
            LocalDate scheduledDateParse = LocalDate.parse(scheduledDate, DateTimeFormatter.ISO_DATE);
            return ResponseEntity.ok(houseWorkService.getHouseWork(scheduledDateParse));
        }

HouseWorkService 수정 전

    @Transactional
        public HouseWorkDateResponseDto getHouseWork(LocalDate scheduledDate){
            List<HouseWork> houseWorkList = houseWorkRepository.findAllByScheduledDate(scheduledDate);
            List<HouseWorkResponseDto> houseWorkResponseDtoList = houseWorkList.stream().map(houseWork -> {
                List<MemberDto> memberDtoList = memberRepository.getMemberDtoListByHouseWorkId(houseWork.getHouseWorkId()).stream().map(MemberDto::from).collect(Collectors.toList());
                return HouseWorkResponseDto.from(houseWork, memberDtoList);
            }).collect(Collectors.toList());

            long countDone = houseWorkResponseDtoList.stream().filter(HouseWorkResponseDto::getSuccess).count();
            long countLeft = houseWorkResponseDtoList.stream().filter(houseWorkResponseDto -> !houseWorkResponseDto.getSuccess()).count();

            return HouseWorkDateResponseDto.from(scheduledDate, countDone, countLeft, houseWorkResponseDtoList);
        }

---

HouseWorkController 수정 후

    @GetMapping(value = "")
        public ResponseEntity<HouseWorkDateResponseDto> getHouseWork(@RequestParam("scheduledDate") String scheduledDate,
                                                                     @RequestMemberId Long memberId){
            LocalDate scheduledDateParse = LocalDate.parse(scheduledDate, DateTimeFormatter.ISO_DATE);
            return ResponseEntity.ok(houseWorkService.getHouseWork(scheduledDateParse, memberId));
        }

HouseWorkServie 수정 후

    @Transactional
        public HouseWorkDateResponseDto getHouseWork(LocalDate scheduledDate, Long memberId){
            Member member = memberRepository.findById(memberId).orElseThrow(() -> new MemberTokenNotFoundException("존재하지 않는 id"));
            List<Assignment> assignmentList = assignmentRepository.findAllByMember(member);
             List<HouseWork> houseWorkList = assignmentList.stream().map(assignment -> assignment.getHouseWork())
                    .filter(houseWork -> houseWork.getScheduledDate().isEqual(scheduledDate)).collect(Collectors.toList());

            List<HouseWorkResponseDto> houseWorkResponseDtoList = houseWorkList.stream().map(houseWork -> {
                List<MemberDto> memberDtoList = memberRepository.getMemberDtoListByHouseWorkId(houseWork.getHouseWorkId()).stream().map(MemberDto::from).collect(Collectors.toList());

                return HouseWorkResponseDto.from(houseWork, memberDtoList);
            }).collect(Collectors.toList());

            long countDone = houseWorkResponseDtoList.stream().filter(HouseWorkResponseDto::getSuccess).count();
            long countLeft = houseWorkResponseDtoList.stream().filter(houseWorkResponseDto -> !houseWorkResponseDto.getSuccess()).count();

            return HouseWorkDateResponseDto.from(scheduledDate, countDone, countLeft, houseWorkResponseDtoList);
        }

Member-HouseWork 관계가 N:N → 중간에 Assignment 테이블을 둔 상황에서 JPA로 이들의 조인관계를 불러오기가 어려웠다.

• HouseWork 도메인에 AssignmentId가 없다
• findAll 파라미터로 List<Assignment>를 줘도 잘 가져올까

 

처음 작성했던 Service 코드 - 에러

    Member member = memberRepository.findAllById(memberId);
    List<Assignment> assignmentList = assignmentRepository.findAllByMember(member);
    List<HouseWork> houseWorkList = houseWorkRepository.findAllByScheduledDateAndAssignmentsEq(scheduledDate, assignmentList);

수정한 Service

    Member member = memberRepository.findById(memberId).orElseThrow(() -> new MemberTokenNotFoundException("존재하지 않는 id"));
    List<Assignment> assignmentList = assignmentRepository.findAllByMember(member);
    List<HouseWork> houseWorkList = assignmentList.stream().map(assignment -> assignment.getHouseWork())
                    .filter(houseWork -> houseWork.getScheduledDate().isEqual(scheduledDate)).collect(Collectors.toList());

• 관계가 복잡해서 그냥 querydsl로 작성해야 하나 싶었지만, scheduledDate를 findAll의 파라미터로 주지 않고 stream().filter()로 처리하니 조회에 성공했다!
• Member 객체를 받아올 때, findAllById로 받지 말고 findById + 예외처리 해주기

 

😅 Comment

아직 JPA보다 쿼리가 편하다..